[tmpnet] Use Api Node Instead of URI in CreateSubnets #4263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a stale URI issue in subnet creation by passing the API node object instead of a pre-fetched URI string. This prevents errors when nodes restart and change ports between URI fetching and validator addition.
- Modifies
CreateSubnetsfunction to accept a*Nodeparameter instead of a URI string - Updates the Bootstrap method to pass the node object directly
- Ensures fresh URI is obtained after node restarts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
maru-ava
approved these changes
Sep 11, 2025
joshua-kim
approved these changes
Sep 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Sam Liokumovich <65994425+samliok@users.noreply.github.com>
felipemadero
pushed a commit
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Sam Liokumovich <65994425+samliok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In the case of a restart, the nodes URI may have changed to a different port. Previously this would have caused errors later on when adding the validators since we were passing in a stale URI.
How this works
How this was tested
Need to be documented in RELEASES.md?