refactor: use reflect.TypeFor #4211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wmypku <wmypku@outlook.com>
StephenButtolph
requested changes
Aug 26, 2025
| func TestVMServerInterface(t *testing.T) { | ||
| var wantMethods, gotMethods []string | ||
| pb := reflect.TypeOf((*vmpb.VMServer)(nil)).Elem() | ||
| pb := reflect.TypeFor[vm.VMServer]() |
Contributor
There was a problem hiding this comment.
It seems that we should also be using this below here and in the codec/reflectcodec package.
Author
There was a problem hiding this comment.
I don't think there are any places that can be replaced anymore;
You can perform a global search for the keyword (nil)).Elem. 😄
Contributor
|
closing in favor of #4311. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Try to use better api reflect.TypeFor instead of reflect.TypeOf when we have known the type.
More info golang/go#60088
How this works
How this was tested
Need to be documented in RELEASES.md?