Add HeightIndex interface to database #4133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Jul 29, 2025
DracoLi
force-pushed
the
dl/blockdb-interface
branch
from
d1c75ba to
dfc9873
Compare
DracoLi
requested review from
a team and
maru-ava
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new BlockDatabase interface to the database package to provide a standardized API for blockchain block storage and retrieval operations. This interface will enable VM integration with the x/blockdb component.
- Introduces
BlockDatabaseinterface with methods for block CRUD operations - Adds inspection and resource management capabilities to the interface
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Draco <draco@dracoli.com>
maru-ava
approved these changes
Aug 25, 2025
Contributor
|
Does this have a target consumer (i.e. simplex)? |
Contributor
Author
|
@maru-ava yes, coreth will be using this first. I'm working on a PR to switch it to use blockdb. |
Contributor
Maybe link the coreth PR that depends on this PR so that the intention is clear? |
yacovm
approved these changes
Aug 28, 2025
joshua-kim
reviewed
Sep 2, 2025
joshua-kim
reviewed
Sep 2, 2025
joshua-kim
approved these changes
Sep 4, 2025
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Draco <draco@dracoli.com>
StephenButtolph
approved these changes
Sep 22, 2025
StephenButtolph
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Add an
BlockDatabaseinterface todatabasepackage. This will be used by the VMs to integrate x/blockdb, starting with coreth (see POC PR).How this works
Interface added to
database/database.goHow this was tested
Need to be documented in RELEASES.md?
No