Simplify test block creation #4095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Jul 16, 2025
Comment on lines
-160
to
-161
| // TestVerifyPrevIsLatest tests that a block with a prev digest that is not found in the block tracker | ||
| // successfully verifies the block if it is the latest accepted block. |
Contributor
Author
There was a problem hiding this comment.
This test was no longer relevant. It seems like this test was written for a previous version of the code.
samliok
reviewed
Jul 17, 2025
Contributor
samliok
left a comment
samliok
left a comment
There was a problem hiding this comment.
overall I like the changes, just that one case i commented is weird
| digest := computeDigest(bytes) | ||
| block.digest = digest | ||
|
|
||
| block.blockTracker = newBlockTracker(block) |
Contributor
There was a problem hiding this comment.
it feels weird to set the blockTracker with the block we are returning. This means newBlock.index() would succeed.
genesis := newBlock(t, newBlockConfig{})
err := genesis.blockTracker.indexBlock(ctx, genesis.digest)
require.NoError(t, err) // this should error
Contributor
Author
There was a problem hiding this comment.
Talked offline and decided that calling indexBlock with a previously accepted hash is unexpected (and therefore undefined behavior).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Reduces the number of options required to provide to the
newBlocktest helper.How this works
How this was tested
Need to be documented in RELEASES.md?