Skip to content

Rename test_util -> util_test #4054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephenButtolph merged 1 commit into from
Jul 7, 2025
Merged

Rename test_util -> util_test #4054

StephenButtolph merged 1 commit into from
Jul 7, 2025

Conversation

@samliok
Copy link
Contributor

@samliok samliok commented Jul 7, 2025

Why this should be merged

So we can use testing packages in our test helpers

Non-test Go files importing test-only packages MUST (a) be in *test package; or (b) be in /tests/ directory:

How this works

How this was tested

Need to be documented in RELEASES.md?

Copilot AI review requested due to automatic review settings July 7, 2025 18:52
@samliok samliok requested a review from StephenButtolph as a code owner July 7, 2025 18:52
Copilot AI reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 7, 2025
Merged via the queue into master with commit 372f031 Jul 7, 2025
29 checks passed
@StephenButtolph StephenButtolph deleted the simplex-test-util branch July 7, 2025 19:31
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Jul 7, 2025
@ethanj ethanj mentioned this pull request Jul 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@yacovm yacovm yacovm approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

Assignees

No one assigned

Labels

None yet

Projects

avalanchego
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samliok @yacovm @StephenButtolph