-
Notifications
You must be signed in to change notification settings - Fork 807
chore: move windows from tier 3 to unsupported #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR downgrades Windows support from Tier 3 to unsupported, removes Windows-specific CI steps, and cleans up the related workflow file.
- Update Windows support tier in the README
- Remove Windows runner and timeout in CI matrix
- Delete the standalone Windows build workflow and its lint exception
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
scripts/actionlint.sh | Removed the skip rule for the now-deleted Windows build workflow |
README.md | Changed Windows support tier from “3” to “Not supported” |
.github/workflows/ci.yml | Excluded windows-2022 from the test matrix and removed its timeout setting |
.github/workflows/build-win-release.yml | Deleted the Windows release build workflow |
I see that's handled separately by #4032 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Will wait to see if there is any pushback
Ya I split these out into two as I thought this was the minimum changes needed to deprecate official windows support ie. testing and generating releases. The follow on is if we also want to delete the work we've done, so that it can run on windows, which I don't think is strictly necessary. |
Why this should be merged
This PR moves Windows from Tier 3 support to Unsupported according to the support tiers outlined in the README.
How this was tested
CI
Need to be documented in RELEASES.md?
Yes.
Notes on Retained Windows Specific Support
Opted to leave windows specific support in place rather than remove it in this PR because the intent is to downgrade the guarantee of support, but this does not mean we need to remove the existing windows specific support. If preferred, we can remove all windows specific handling as well.
The following files contain windows specific handling or references based on a search of the codebase:
avalanchego/vms/rpcchainvm/runtime/subprocess/linux_stopper.go
Line 7 in 092cf18
avalanchego/utils/ulimit/ulimit_windows.go
Line 13 in 092cf18
avalanchego/utils/storage/storage_windows.go
Line 4 in 092cf18
avalanchego/utils/perms/write_file.go
Line 15 in 092cf18
avalanchego/tests/fixture/tmpnet/detached_process_windows.go
Line 11 in 092cf18