Skip to content

Conversation

aaronbuchwald
Copy link
Collaborator

Why this should be merged

This PR moves Windows from Tier 3 support to Unsupported according to the support tiers outlined in the README.

How this was tested

CI

Need to be documented in RELEASES.md?

Yes.

Notes on Retained Windows Specific Support

Opted to leave windows specific support in place rather than remove it in this PR because the intent is to downgrade the guarantee of support, but this does not mean we need to remove the existing windows specific support. If preferred, we can remove all windows specific handling as well.

The following files contain windows specific handling or references based on a search of the codebase:

@aaronbuchwald aaronbuchwald marked this pull request as ready for review June 24, 2025 13:58
@Copilot Copilot AI review requested due to automatic review settings June 24, 2025 13:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades Windows support from Tier 3 to unsupported, removes Windows-specific CI steps, and cleans up the related workflow file.

  • Update Windows support tier in the README
  • Remove Windows runner and timeout in CI matrix
  • Delete the standalone Windows build workflow and its lint exception

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/actionlint.sh Removed the skip rule for the now-deleted Windows build workflow
README.md Changed Windows support tier from “3” to “Not supported”
.github/workflows/ci.yml Excluded windows-2022 from the test matrix and removed its timeout setting
.github/workflows/build-win-release.yml Deleted the Windows release build workflow

@maru-ava
Copy link
Contributor

maru-ava commented Jun 24, 2025

Do we also want to remove usage of go:build windows?

I see that's handled separately by #4032

Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Will wait to see if there is any pushback

@aaronbuchwald
Copy link
Collaborator Author

Do we also want to remove usage of go:build windows?

I see that's handled separately by #4032

Ya I split these out into two as I thought this was the minimum changes needed to deprecate official windows support ie. testing and generating releases. The follow on is if we also want to delete the work we've done, so that it can run on windows, which I don't think is strictly necessary.

@aaronbuchwald aaronbuchwald enabled auto-merge June 25, 2025 14:20
@aaronbuchwald aaronbuchwald added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit 9374053 Jun 25, 2025
27 checks passed
@aaronbuchwald aaronbuchwald deleted the deprecate-windows-support branch June 25, 2025 14:39
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants