Move HTTP2 routing information into headers #4001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
commented
Jun 9, 2025
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
mpignatelli12
approved these changes
Jun 9, 2025
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
StephenButtolph
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Modifying the http2
:pathis hacky because it's typically a read-only value, and supporting other tools like postman/grpcurl require more hacks where we have to keep injecting this valueHow this works
Moves the chain id information into an http header, which tooling generally has access to read/write to
How this was tested
xsvm e2e test
Need to be documented in RELEASES.md?
No (this feature wasn't released yet)