-
Notifications
You must be signed in to change notification settings - Fork 749
Add linkspector CI action #3939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The linter is falsely rejecting |
Link to prometheus repo fails no matter where I link within the repo |
It was reporting 429 (rate limited) so I had assumed locally it was because I had just hit it too many time locally... Seems like github has some aggressive RL... Switched to the (probably better) hosted rendering of the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new CI action for link checking using linkspector, while also updating various documentation links and file paths to reflect recent restructurings.
- Update README and related docs to reference new paths and packages
- Fix typos and adjust link anchors for consistency
- Introduce a new CI workflow for link linting
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
vms/example/xsvm/README.md | Updated package and link references to use the new interchain messaging. |
tests/fixture/e2e/describe.go | Fixed a spelling mistake in a comment. |
tests/e2e/README.md | Adjusted file path references; updated link anchor (potential issue). |
tests/antithesis/README.md | Updated Antithesis documentation link. |
snow/README.md | Changed absolute links to relative links for networking components. |
genesis/README.md | Updated genesis file link to a relative path. |
config/config.md | Updated genesis documentation links. |
api/metrics/service.md | Updated Prometheus documentation link. |
README.md | Modified link anchor for autogenerated mocks section (potential issue). |
.linkspector.yml | Added configuration for link checking, excluding specific files/patterns. |
.github/workflows/ci.yml | Added a new CI job for markdown links linting via linkspector. |
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: umbrelladocs/action-linkspector@a0567ce1c7c13de4a2358587492ed43cab5d0102 #v1.3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to be able to check this locally without an action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme here talks about how to run it locally: https://github.com/UmbrellaDocs/linkspector. I found it useful to run locally. Would we want this added as a task + nix dep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task + nix dep sounds good.
Pull Request is not mergeable
Why this should be merged
We currently have a number of broken links:
How this works
After merging this action will NOT become required, as sometimes the external websites are flaky.
How this was tested
Running
linkspector check -s
locally. (After this PR, the action behavior will need to be validated)Can be installed locally with
npm install -g @umbrelladocs/linkspector
Need to be documented in RELEASES.md?
No.