Add P-Chain state test #3924
Merged
Add P-Chain state test #3924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test case to ensure that inactive L1 validators can have their weights updated correctly.
- Introduces a new test vector titled "increase inactive weight" that simulates increasing the weight of an inactive validator.
- Verifies that validator weight modifications work as expected for inactive L1 validators.
Comments suppressed due to low confidence (1)
vms/platformvm/state/state_test.go:1630
- [nitpick] Consider adding explicit assertions within the test to verify that the inactive validator's weight has been correctly updated after processing the state change.
{
maru-ava
approved these changes
May 1, 2025
| name: "increase inactive weight", | ||
| initial: []L1Validator{ | ||
| { | ||
| ValidationID: l1Validator.ValidationID, |
Contributor
There was a problem hiding this comment.
(No action required) For a future PR: ValidationID, SubnetID, NodeID and PublicKey rarely vary, maybe set in a case only when the default value should not be used and otherwise set in the test.
joshua-kim
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds a test case to ensure that inactive L1 validators can have their weights modified correctly.
How this works
Adds another test vector.
How this was tested
CI
Need to be documented in RELEASES.md?
No.