Ensure HTTP headers are propagated through the rpcchainvm #3917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
commented
Apr 29, 2025
vms/rpcchainvm/ghttp/http_test.go
Outdated
| request := &http.Request{ | ||
| Body: io.NopCloser(strings.NewReader("bar")), | ||
| Header: http.Header{ | ||
| "Upgrade": {"upgrade"}, |
Contributor
Author
There was a problem hiding this comment.
We have to specify this header because this fixes the bug when we're not using http simple. I'm also wondering if we should just remove serveHTTPSimple entirely...
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
StephenButtolph
previously approved these changes
Apr 30, 2025
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
StephenButtolph
approved these changes
Apr 30, 2025
StephenButtolph
changed the title
maru-ava
reviewed
Apr 30, 2025
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
maru-ava
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Factored out of #3294
How this works
Introduces a rpc to sync the headers from the plugin vm. Our current implementation does not work because the headers is just a map/not an interface, so any modifications to the map are not synced across avalanchego <-> the plugin.
How this was tested
Added a regression test
Need to be documented in RELEASES.md?
Yes