fix rpcchainvm handling for arbitrary length http body #3910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
changed the title
joshua-kim
force-pushed
the
rpcchainvm-bug-fix
branch
3 times, most recently
from
ac8fb6d to
11b1ef5
Compare
joshua-kim
changed the title
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
rpcchainvm-bug-fix
branch
from
11b1ef5 to
8511ffd
Compare
joshua-kim
commented
Apr 24, 2025
Comment on lines
29
to
31
| if err != nil { | ||
| return 0, err | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I think it's fine for us to just return the error here. io.EOF is a special error for both grpc and io.Reader (ref). io.EOF's invariants on io.Reader are particularly confusing though.
Contributor
|
Also - linting seems to be failing |
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
StephenButtolph
approved these changes
Apr 24, 2025
tsachiherman
approved these changes
Apr 25, 2025
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
looks functionally correct to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes a bug in rpcchainvm where a arbitrary length http body will hang when attempting to copy the body into protobuf.
How this works
Instead of copying the body into a proto message, wrap the http body in an implementation of
io.Readerthat streams the message body.How this was tested
Added a regression test
Need to be documented in RELEASES.md?
Yes