Skip to content

Conversation

@felipemadero
Copy link
Contributor

Why this should be merged

Defines some exports as needed by CLI integration of tmpnet

How this works

How this was tested

Need to be documented in RELEASES.md?

Copy link
Contributor

@maru-ava maru-ava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment or docstring to each of the exported methods communicating to future maintainers the need to keep them exported despite the lack of consumers within avalanchego.

@maru-ava maru-ava enabled auto-merge March 20, 2025 16:44
@maru-ava maru-ava added this pull request to the merge queue Mar 20, 2025
@StephenButtolph StephenButtolph removed this pull request from the merge queue due to a manual request Mar 20, 2025
@StephenButtolph
Copy link
Contributor

Going to wait until v1.13.0 to merge this (so that v1.13.0-rc.0 aligns correctly with v1.13.0)

@StephenButtolph StephenButtolph changed the title set tmpnet exports for CLI interface Export tmpnet functions for CLI interface Mar 21, 2025
@StephenButtolph StephenButtolph added this pull request to the merge queue Mar 21, 2025
Merged via the queue into master with commit edd2a48 Mar 21, 2025
23 checks passed
@StephenButtolph StephenButtolph deleted the tmpnet-exports branch March 21, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants