Remove RequestBuildBlock on P-Chain Mempool #3705
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
remove-request-build-block
branch
from
d91b0c3 to
20cc896
Compare
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This function doesn't seem to belong on the mempool type because consensus is responsible for building the block. I think another alternative would be to put
RequestBuildBlockonto a static function somewhere, but I'm not sure where it would live (probably not the mempool package) + I don't think the cost of duplicate code is bad here.How this works
Removes
RequestBuildBlockand replaces the usage of it with usage of thetoEnginechannelHow this was tested
CI
Need to be documented in RELEASES.md?
No