[tmpnet] Re-enable reuse of dynamically allocated API ports #3697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By popular demand, tmpnet will once again attempt to reuse dynamically allocated API ports. The only difference is that this needs to be explicitly configured (via Network.DefaultRuntimeConfig.ReuseDynamicPorts) to allow for an error to be reported if a network so configured is started with a kube runtime.
iansuvak
approved these changes
Feb 4, 2025
Contributor
iansuvak
left a comment
iansuvak
left a comment
There was a problem hiding this comment.
LGTM and thanks! I am guessing the error report if this is attempted to be used from Kube runtime would be handled elsewhere?
Contributor
Author
Yes, kube support is still in progress. |
aaronbuchwald
approved these changes
Feb 4, 2025
Collaborator
aaronbuchwald
left a comment
aaronbuchwald
left a comment
There was a problem hiding this comment.
LGTM - what's the reason for removing this feature and now bringing it back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
By popular demand, tmpnet will once again attempt to reuse dynamically allocated API ports. The only difference is that this needs to be explicitly configured (via
Network.DefaultRuntimeConfig.ReuseDynamicPorts) to allow for an error to be reported if a network so configured is started with a kube runtime.How this works
ReuseDynamicPortsis setHow this was tested
CI
Need to be documented in RELEASES.md?
N/A