-
Notifications
You must be signed in to change notification settings - Fork 807
Fix change/range proofs + simplify the code #3688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
33e69e1
to
923f088
Compare
This PR has become stale because it has been open for 30 days with no activity. Adding the |
x/merkledb/proof_test.go
Outdated
{ | ||
name: "happy path", | ||
malform: func(*Proof) {}, | ||
expectedErr: nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We can remove this line since the zero value is already nil
... or not if you want to be explicit (I would personally leave it as nil but I can see the reasoning for not doing so). Leaving this to developer preference.
1fa3412
to
e087730
Compare
8ec99b0
to
a278f75
Compare
430e031
to
842f70d
Compare
d64460a
to
76ab1b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(didn't actually review, x/
shouldn't require multiple reviews.)
Why this should be merged
Fixing proof verification bugs:
This issues were mainly affecting the simple proofs verification, but also change/range proofs.
And also, simplifying the code for better readability and maintainability.
How this works
How this was tested
UTs
Need to be documented in RELEASES.md?