Skip to content

Conversation

@StephenButtolph
Copy link
Contributor

Why this should be merged

The Keystore API has been deprecated for almost 2 years. Since Etna was recently activated, now is the ideal time to remove it.

How this works

This PR removes all code related to the keystore.

How this was tested

CI

Need to be documented in RELEASES.md?

Yes.

@StephenButtolph StephenButtolph marked this pull request as ready for review January 17, 2025 18:15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meaghanfitzgerald Is there a change that needs to be made to the docs repo with the removal of this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keystore API has been marked deprecated in the docs since March 2023. Once this PR is merged, we should include "[DEPRECATED]" in the title and sidebar, and remove the documentation entirely after about 4-6 weeks. cc: @owenwahlgren @ashucoder9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the Keystore API from docs, and marked as deprecated for those who view w direct link. changes should be live once the builders hub pr is live.

@meaghanfitzgerald
Copy link
Contributor

cc: @Andyvargtz

@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 18, 2025
Merged via the queue into master with commit 0e994f6 Jan 18, 2025
22 checks passed
@StephenButtolph StephenButtolph deleted the remove-keystore branch January 18, 2025 01:26
@danlaine
Copy link

Congrats on finally being able to remove this API lol 🥳

tsachiherman pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants