Reintroduce the deprecated info.getTxFee API
#3656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samliok
approved these changes
Jan 16, 2025
StephenButtolph
changed the title
info.getTxFee API
marun
approved these changes
Jan 16, 2025
meaghanfitzgerald
approved these changes
Jan 16, 2025
| NetworkID uint32 | ||
| VMManager vms.Manager | ||
| Upgrades upgrade.Config | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| NetworkID: n.Config.NetworkID, | ||
| VMManager: n.VMManager, | ||
| Upgrades: n.Config.UpgradeConfig, | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
tsachiherman
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This API can't be removed without a deprecation window. It'll likely be removed in a few releases.
How this works
Reintroduces
info.getTxFeein a minimally invasive way and marks it as deprecated.How this was tested
Manually.
Need to be documented in RELEASES.md?
Done.