[ci] Fix post-merge protobuf lint job breakage #3644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without push being explicitly disabled on the lint job, it will attempt to push when run post-merge. Without a buf token, that push will fail. The `buf-push` is responsible for pushing so there's no reason for the lint job to attempt it.
qdm12
approved these changes
Jan 9, 2025
StephenButtolph
approved these changes
Jan 9, 2025
tsachiherman
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Without push being explicitly disabled on the lint job, it will attempt to push when run post-merge. Without a buf token, that push will fail. The
buf-pushis responsible for pushing so there's no reason for the lint job to attempt it.How this works
Disables push for the protobuf lint job
How this was tested
CI
Need to be documented in RELEASES.md?
N/A