[testing] Always use the go.mod version of ginkgo #3618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
unify-ginkgo-version
branch
from
41ce3a6 to
96fa133
Compare
marun
force-pushed
the
unify-ginkgo-version
branch
from
96fa133 to
c30832b
Compare
marun
force-pushed
the
unify-ginkgo-version
branch
3 times, most recently
from
60f4f5b to
860f29b
Compare
Previously, ginkgo was installed with an explicit version which made it easy for the ginkgo command and the test code to be using different versions. Using `go run` without a tag ensures that the go.mod version of ginkgo is always used for the command.
marun
force-pushed
the
unify-ginkgo-version
branch
from
860f29b to
934d00b
Compare
qdm12
approved these changes
Dec 23, 2024
darioush
approved these changes
Dec 23, 2024
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: marun <maru.newby@avalabs.org>
|
|
||
| KUBECONFIG="$HOME/.kube/config" PATH="${PWD}/bin:$PATH" ginkgo -v ./tests/fixture/bootstrapmonitor/e2e | ||
| KUBECONFIG="$HOME/.kube/config" PATH="${PWD}/bin:$PATH" \ | ||
| ./scripts/ginkgo.sh -v ./tests/fixture/bootstrapmonitor/e2e |
Contributor
There was a problem hiding this comment.
was this indentation intended?
StephenButtolph
approved these changes
Dec 23, 2024
tsachiherman
pushed a commit
that referenced
this pull request
Jan 29, 2025
Signed-off-by: marun <maru.newby@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously, ginkgo was installed with an explicit version which made it easy for the ginkgo command and the test code to be using different versions.
How this works
scripts/ginkgo.shthat wrapsgo runexecution with the go.mod version of ginkgoHow this was tested
CI
Need to be documented in RELEASES.md?
N/A