Skip to content

Conversation

@ceyonur
Copy link
Contributor

@ceyonur ceyonur commented Dec 11, 2024

Why this should be merged

Bumps coreth dependency & removes direct plugin/evm dependency in tests/wallet.

How this works

This pull request includes several changes to update the codebase, primarily focusing on replacing the evm package with the atomic package and simplifying the retrieval of Ethereum addresses. The most important changes include modifying import statements, updating function calls, and refactoring methods related to Ethereum addresses.

Package Replacement and Refactoring:

  • Updated import statements across multiple files to replace github.com/ava-labs/coreth/plugin/evm with github.com/ava-labs/coreth/plugin/evm/atomic. [1] [2] [3] [4]
  • Modified function calls to use the atomic package instead of the evm package. [1] [2] [3]

Ethereum Address Retrieval:

  • Refactored methods to use the new EthAddress() function for retrieving Ethereum addresses from keys, replacing the previous evm.GetEthAddress method. [1] [2] [3]
  • Added EthAddress() methods to the PublicKey and PrivateKey structs in utils/crypto/secp256k1/secp256k1.go. [1] [2]

Test and Fixture Updates:

  • Removed unused evm import statements from test files and updated the usage of Ethereum address retrieval methods. [1] [2] [3]
  • Updated test and fixture methods to use the new EthAddress() method for consistency. [1] [2] [3]

These changes collectively enhance the codebase by simplifying the retrieval of Ethereum addresses and consolidating the use of the atomic package.

How this was tested

Existing UTs should cover.

Need to be documented in RELEASES.md?

No

@ceyonur ceyonur changed the title bump coreth coreth atomic pkg dependency Dec 11, 2024
@ceyonur ceyonur self-assigned this Dec 30, 2024
@ceyonur ceyonur marked this pull request as ready for review December 30, 2024 19:40
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit a8cc764 Jan 3, 2025
22 checks passed
@StephenButtolph StephenButtolph deleted the fix-coreth-wallet-dep branch January 3, 2025 17:58
tsachiherman pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants