-
Notifications
You must be signed in to change notification settings - Fork 840
coreth atomic pkg dependency #3588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go into fix-coreth-wallet-dep
marun
approved these changes
Dec 30, 2024
darioush
approved these changes
Dec 30, 2024
qdm12
approved these changes
Dec 31, 2024
StephenButtolph
approved these changes
Jan 3, 2025
tsachiherman
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Bumps coreth dependency & removes direct
plugin/evmdependency in tests/wallet.How this works
This pull request includes several changes to update the codebase, primarily focusing on replacing the
evmpackage with theatomicpackage and simplifying the retrieval of Ethereum addresses. The most important changes include modifying import statements, updating function calls, and refactoring methods related to Ethereum addresses.Package Replacement and Refactoring:
github.com/ava-labs/coreth/plugin/evmwithgithub.com/ava-labs/coreth/plugin/evm/atomic. [1] [2] [3] [4]atomicpackage instead of theevmpackage. [1] [2] [3]Ethereum Address Retrieval:
EthAddress()function for retrieving Ethereum addresses from keys, replacing the previousevm.GetEthAddressmethod. [1] [2] [3]EthAddress()methods to thePublicKeyandPrivateKeystructs inutils/crypto/secp256k1/secp256k1.go. [1] [2]Test and Fixture Updates:
evmimport statements from test files and updated the usage of Ethereum address retrieval methods. [1] [2] [3]EthAddress()method for consistency. [1] [2] [3]These changes collectively enhance the codebase by simplifying the retrieval of Ethereum addresses and consolidating the use of the
atomicpackage.How this was tested
Existing UTs should cover.
Need to be documented in RELEASES.md?
No