add L1 support to getCurrentValidators API #3564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
…go into add-l1-validators-api
marun
reviewed
Dec 2, 2024
| PublicKey: otherPK, | ||
| Weight: 1, | ||
| StartTime: now, | ||
| StartTime: now.Add(1 * time.Second), |
Contributor
There was a problem hiding this comment.
(No action required) Why does the start time change in these tests?
Contributor
Author
There was a problem hiding this comment.
stakers should come before L1 validators and I wanted to test out different timestamps
Contributor
There was a problem hiding this comment.
Should this be reversed then? Or we can add more test cases.
StephenButtolph
approved these changes
Jan 23, 2025
StephenButtolph
previously approved these changes
Jan 23, 2025
StephenButtolph
dismissed
their stale review
I'm going to stop approving until after CI finishes lol
StephenButtolph
approved these changes
Jan 23, 2025
yacovm
reviewed
Jan 23, 2025
yacovm
reviewed
Jan 23, 2025
yacovm
reviewed
Jan 23, 2025
darioush
approved these changes
Jan 23, 2025
qdm12
reviewed
Jan 24, 2025
| - `platform.getValidatorFeeConfig` | ||
| - `platform.getValidatorFeeState` | ||
| - `validationID` to `platform.getL1Validator` results | ||
| - L1 validators to `platform.getCurrentValidators` |
Contributor
There was a problem hiding this comment.
nit just a tiny bit clearer imo:
Suggested change
| - L1 validators to `platform.getCurrentValidators` | |
| - L1 validators are now listed in `platform.getCurrentValidators` |
Contributor
Author
There was a problem hiding this comment.
I think it contradicts with -Added: above
| PublicKey: otherPK, | ||
| Weight: 1, | ||
| StartTime: now, | ||
| StartTime: now.Add(1 * time.Second), |
Contributor
There was a problem hiding this comment.
Should this be reversed then? Or we can add more test cases.
qdm12
reviewed
Jan 24, 2025
| SubnetID: subnetID, | ||
| } | ||
| reply := GetCurrentValidatorsReply{} | ||
| require.NoError(service.GetCurrentValidators(&http.Request{}, &args, &reply)) |
Contributor
There was a problem hiding this comment.
nit split those so it's more readable
Suggested change
| require.NoError(service.GetCurrentValidators(&http.Request{}, &args, &reply)) | |
| err = service.GetCurrentValidators(&http.Request{}, &args, &reply) | |
| require.NoError(err) |
Contributor
There was a problem hiding this comment.
I think this actually fails linting if applied.
Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
…valanchego into add-l1-validators-api
tsachiherman
pushed a commit
that referenced
this pull request
Jan 29, 2025
Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Signed-off-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It adds L1 support and shows L1 validators in
platform.getCurrentValidatorsAPI.How this works
validationIDto theplatform.getL1ValidatorAPI outputs.platform.getCurrentValidatorsAPI.PermissionedValidatorstruct as it is no longer used.getL1ValidatorsandgetPrimaryOrSubnetValidatorsmethods to handle fetching validators based on subnet ID.convertL1ValidatorToAPImethod to convert L1 validator data to API format.GetL1Validatorsmethod to theStateinterface to return both base stakers and L1 validators in a converted L1.How this was tested
Locally
Need to be documented in RELEASES.md?
Yes, updated.