ACP-77: Filter the inactive validator from block proposals and tx gossip #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
approved these changes
Oct 31, 2024
marun
approved these changes
Oct 31, 2024
joshua-kim
reviewed
Oct 31, 2024
joshua-kim
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
After ACP-77, inactive validators are grouped into a single
EmptyNodeIDentry. ThisEmptyNodeIDshould not be considered for block production or transaction gossip.How this works
Filters the
EmptyNodeIDfrom the validator set prior to the usage for tx gossip and generation of the proposal list.How this was tested
Added unit tests.
Need to be documented in RELEASES.md?
This is not a user facing change.