Move RPC metrics registration after its client's initialization #3488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes no sense to have a metrics collector that uses RPC invocations to be registered before its RPC client has been initialized. Changed the order of initialization accordingly. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
aaronbuchwald
approved these changes
Oct 23, 2024
StephenButtolph
approved these changes
Oct 23, 2024
yacovm
added a commit
to yacovm/avalanchego
that referenced
this pull request
Oct 25, 2024
…labs#3488) Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
yacovm
added a commit
to yacovm/avalanchego
that referenced
this pull request
Oct 25, 2024
…labs#3488) Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It makes no sense to have a metrics collector that uses RPC invocations to be registered before its remote RPC service has been initialized.
Changed the order of initialization accordingly.
How this works
Switched initialization order of gRPC Initialize invocation and the metrics registration.
How this was tested
CI