Add Expiry Replay Protection #3379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
changed the title
StephenButtolph
changed the base branch from
master
to
replace-iterator-test-helper
This was referenced Sep 11, 2024
Merged
StephenButtolph
changed the base branch from
master
to
implement-deduplication-iterator
joshua-kim
approved these changes
Sep 11, 2024
StephenButtolph
commented
Sep 11, 2024
aaronbuchwald
approved these changes
Sep 12, 2024
StephenButtolph
deleted the
implement-acp-77-add-validator-replay-protection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR introduces the ACP-77 validation expiry state. It supports maintaining a set of
ExpiryEntrys and iterating over them from lower to higher timestamps.DeleteExpirywill be usedRegisterValidatorTx-HasExpirywill be used to very that the tx isn't being replayed.RegisterValidatorTx-PutExpirywill be used to prevent replaying in a following transaction.How this works
There is one interesting oddity. Specifically, I wanted the interface of the
state.Chainto make no assumptions on the usage pattern. Even though we should never callPutExpirywhen theExpiryEntryalready exists, this implementation handles that gracefully by deduplicating values between theaddedtree and parent/baseexpirytree.How this was tested