feat(GitHub): migrate configure-aws-credentials steps to IAM role assumption #3377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
approved these changes
Sep 10, 2024
StephenButtolph
previously approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Should we be updating these here as well?
avalanchego/.github/workflows/build-public-ami.yml
Lines 50 to 55 in 8974ed8
It does use a different access key tho.. so might be intended
Updated |
StephenButtolph
approved these changes
Sep 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This improves the security and we can get rid of using static AWS credentials
How this works
The configure-aws-credentials now assumes pre-configured IAM role
How this was tested
We successfully used this approach for another repos