Support unmarshalling of json byte slices #3354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
approved these changes
Sep 3, 2024
| require.NoError(err) | ||
| require.Equal(test.expectedJSON, string(jsonBytes)) | ||
|
|
||
| var unmarshaled JSONByteSlice |
There was a problem hiding this comment.
Does this need to support overwriting existing data (related to my comment about unmarshalling "null")? If so, set this to something non-empty to begin with.
There was a problem hiding this comment.
I added an explicit test for the null behavior
samliok
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
JSONByteSlicecurrently doesn't implementUnmarshalJSON. This is pretty unusual (and is something that is desired for #3217.How this works
nilUnmarshalJSONHow this was tested
nilas"0x"