Skip to content

Rename race condition image tags #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

Rename race condition image tags #3311

merged 1 commit into from
Aug 21, 2024

Conversation

cam-schultz
Copy link
Contributor

Why this should be merged

Replace -race with -r as the suffix for image tags to prevent unfortunate fully-formed tag names.

How this works

See above

How this was tested

CI

@cam-schultz cam-schultz requested a review from marun as a code owner August 19, 2024 20:17
marun
marun approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this has any downstream impact (e.g. docs), but this lgtm otherwise.

@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 21, 2024
Merged via the queue into master with commit 34aa2a3 Aug 21, 2024
@StephenButtolph StephenButtolph deleted the rename-race-cond-tag branch August 21, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenButtolph StephenButtolph StephenButtolph approved these changes

+1 more reviewer

@marun marun marun approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cam-schultz @marun @StephenButtolph