[antithesis] Fix broken flag handling and improve image testing #3299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
commented
Aug 15, 2024
tests/antithesis/config.go
Outdated
| if len(envChainIDs) > 0 { | ||
| // CSV.Set doesn't actually return an error | ||
| _ = uris.Set(envChainIDs) | ||
| _ = chainIDs.Set(envChainIDs) |
There was a problem hiding this comment.
Is the _ just to keep the linter quiet? If so, I think it's better to be precise with //nolint:errcheck // CSV.Set doesn't actually... and then drop the _.
There was a problem hiding this comment.
Done. Note it was necessary to disable 2 linters: //nolint:errcheck,revive
There was a problem hiding this comment.
DIsabled the revive unhandled-error check in favor of errcheck to avoid having to disable 2 linters
marun
commented
Aug 15, 2024
marun
force-pushed
the
antithesis-fix-config
branch
from
c070051 to
bf7647b
Compare
marun
commented
Aug 15, 2024
marun
force-pushed
the
antithesis-fix-config
branch
2 times, most recently
from
43615c5 to
d7389ec
Compare
ARR4N
approved these changes
Aug 15, 2024
tests/antithesis/config.go
Outdated
| if len(envChainIDs) > 0 { | ||
| // CSV.Set doesn't actually return an error | ||
| _ = uris.Set(envChainIDs) | ||
| _ = chainIDs.Set(envChainIDs) |
There was a problem hiding this comment.
Is the _ just to keep the linter quiet? If so, I think it's better to be precise with //nolint:errcheck // CSV.Set doesn't actually... and then drop the _.
StephenButtolph
approved these changes
Aug 15, 2024
The recent addition of tmpnet support for antithesis workloads broke configuration in the actual antithesis environment due to deficiencies in the test of the image build. This change cleans up the flag configuration that caused the problem and updates the test of image build to directly check the output of the docker compose project for evidence that nodes have reported healthy rather than just waiting 30s for a non-zero exit.
marun
force-pushed
the
antithesis-fix-config
branch
from
d7389ec to
f3134ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The recent addition of tmpnet support for antithesis workloads broke configuration in the actual antithesis environment due to deficiencies in the test of the image build.
How this works
This change cleans up the flag configuration that caused the problem and updates the test of image build to directly check the output of the docker compose project for evidence that nodes have reported healthy rather than just waiting for 30s without a non-zero exit.
How this was tested