Add fee.State to P-chain state #3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
abi87,
danlaine and
dhrubabasu
as code owners
1 task
marun
approved these changes
Jul 30, 2024
abi87
reviewed
Jul 31, 2024
| func getFeeState(db database.KeyValueReader) (fee.State, error) { | ||
| feeStateBytes, err := db.Get(FeeStateKey) | ||
| if err == database.ErrNotFound { | ||
| return fee.State{}, nil |
There was a problem hiding this comment.
q: shouldn't the capacity be max here? I believe this case happens only before etna is activated. In such a casa shouldn't capacity be max instead of zero?
There was a problem hiding this comment.
The ACP doesn't specify this... I think that it makes more sense to have it be set to 0 so that the fork activation doesn't have a complexity spike (although I doubt this would really matter).
I'll make a PR to the ACP to clarify this.
There was a problem hiding this comment.
Added this to the spec: avalanche-foundation/ACPs#136. Feel free to comment on that PR if you think it should be a different value.
abi87
reviewed
Jul 31, 2024
abi87
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Dynamic fees needs to track the capacity and excess usage of the chain for rate limiting and fee pricing.
How this works
Adds
GetFeeStateandSetFeeStateto thestate.Chaininterface.How this was tested