Skip to content

Add benchmarks for add and sub fee dimensions #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Add benchmarks for add and sub fee dimensions #3222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
357f92d
added benchmarks for add and sub fee dimensions
abi87 Jul 24, 2024
6f76ae9
improved benchs following code review
abi87 Jul 24, 2024
d33a447
appeased linter
abi87 Jul 24, 2024
24dbe1b
Merge branch 'master' into fee_dimensions_add_benchmark
abi87 Jul 25, 2024
b16ef2d
fixed benchmarks meaning
abi87 Jul 25, 2024
de23f74
passed Dimensions by reference
abi87 Jul 25, 2024
daf3671
expand benchamrks
StephenButtolph Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vms/components/fee/dimensions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type (
// Add returns d + sum(os...).
//
// If overflow occurs, an error is returned.
func (d Dimensions) Add(os ...Dimensions) (Dimensions, error) {
func (d Dimensions) Add(os ...*Dimensions) (Dimensions, error) {
var err error
for _, o := range os {
for i := range o {
Expand All @@ -38,7 +38,7 @@ func (d Dimensions) Add(os ...Dimensions) (Dimensions, error) {
// Sub returns d - sum(os...).
//
// If underflow occurs, an error is returned.
func (d Dimensions) Sub(os ...Dimensions) (Dimensions, error) {
func (d Dimensions) Sub(os ...*Dimensions) (Dimensions, error) {
var err error
for _, o := range os {
for i := range o {
Expand Down
77 changes: 63 additions & 14 deletions vms/components/fee/dimensions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func Test_Dimensions_Add(t *testing.T) {
tests := []struct {
name string
lhs Dimensions
rhs []Dimensions
rhs []*Dimensions
expected Dimensions
expectedErr error
}{
Expand All @@ -28,7 +28,7 @@ func Test_Dimensions_Add(t *testing.T) {
DBWrite: 3,
Compute: 4,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 10,
DBRead: 20,
Expand All @@ -52,7 +52,7 @@ func Test_Dimensions_Add(t *testing.T) {
DBWrite: 3,
Compute: 4,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 10,
DBRead: 20,
Expand Down Expand Up @@ -82,7 +82,7 @@ func Test_Dimensions_Add(t *testing.T) {
DBWrite: 3,
Compute: 4,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 10,
DBRead: 20,
Expand All @@ -106,7 +106,7 @@ func Test_Dimensions_Add(t *testing.T) {
DBWrite: 3,
Compute: 4,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 10,
DBRead: 20,
Expand All @@ -130,7 +130,7 @@ func Test_Dimensions_Add(t *testing.T) {
DBWrite: math.MaxUint64,
Compute: 4,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 10,
DBRead: 20,
Expand All @@ -154,7 +154,7 @@ func Test_Dimensions_Add(t *testing.T) {
DBWrite: 3,
Compute: math.MaxUint64,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 10,
DBRead: 20,
Expand Down Expand Up @@ -186,7 +186,7 @@ func Test_Dimensions_Sub(t *testing.T) {
tests := []struct {
name string
lhs Dimensions
rhs []Dimensions
rhs []*Dimensions
expected Dimensions
expectedErr error
}{
Expand All @@ -198,7 +198,7 @@ func Test_Dimensions_Sub(t *testing.T) {
DBWrite: 33,
Compute: 44,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 1,
DBRead: 2,
Expand All @@ -222,7 +222,7 @@ func Test_Dimensions_Sub(t *testing.T) {
DBWrite: 33,
Compute: 44,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 1,
DBRead: 2,
Expand Down Expand Up @@ -252,7 +252,7 @@ func Test_Dimensions_Sub(t *testing.T) {
DBWrite: 33,
Compute: 44,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: math.MaxUint64,
DBRead: 2,
Expand All @@ -276,7 +276,7 @@ func Test_Dimensions_Sub(t *testing.T) {
DBWrite: 33,
Compute: 44,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 1,
DBRead: math.MaxUint64,
Expand All @@ -300,7 +300,7 @@ func Test_Dimensions_Sub(t *testing.T) {
DBWrite: 33,
Compute: 44,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 1,
DBRead: 2,
Expand All @@ -324,7 +324,7 @@ func Test_Dimensions_Sub(t *testing.T) {
DBWrite: 33,
Compute: 44,
},
rhs: []Dimensions{
rhs: []*Dimensions{
{
Bandwidth: 1,
DBRead: 2,
Expand Down Expand Up @@ -426,3 +426,52 @@ func Test_Dimensions_ToGas(t *testing.T) {
})
}
}

func Benchmark_Dimensions_Add(b *testing.B) {
lhs := Dimensions{600, 10, 10, 1000}
rhs := []*Dimensions{
{1, 1, 1, 1},
{10, 10, 10, 10},
{100, 100, 100, 100},
{200, 200, 200, 200},
{500, 500, 500, 500},
{1_000, 1_000, 1_000, 1_000},
{10_000, 10_000, 10_000, 10_000},
}

b.Run("single", func(b *testing.B) {
for i := 0; i < b.N; i++ {
_, _ = lhs.Add(rhs[0])
}
})

b.Run("multiple", func(b *testing.B) {
for i := 0; i < b.N; i++ {
_, _ = lhs.Add(rhs[0], rhs[1], rhs[2], rhs[3], rhs[4], rhs[5], rhs[6])
}
})
}

func Benchmark_Dimensions_Sub(b *testing.B) {
lhs := Dimensions{10_000, 10_000, 10_000, 100_000}
rhs := []*Dimensions{
{1, 1, 1, 1},
{10, 10, 10, 10},
{100, 100, 100, 100},
{200, 200, 200, 200},
{500, 500, 500, 500},
{1_000, 1_000, 1_000, 1_000},
}

b.Run("single", func(b *testing.B) {
for i := 0; i < b.N; i++ {
_, _ = lhs.Sub(rhs[0])
}
})

b.Run("multiple", func(b *testing.B) {
for i := 0; i < b.N; i++ {
_, _ = lhs.Sub(rhs[0], rhs[1], rhs[2], rhs[3], rhs[4], rhs[5])
}
})
}