[antithesis] Add schedule for workflows #3192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
approved these changes
Jul 15, 2024
ARR4N
approved these changes
Jul 16, 2024
| on: | ||
| # TODO(marun) Add a schedule to execute regularly | ||
| schedule: | ||
| - cron: '0 22 * * *' |
There was a problem hiding this comment.
Added comments for the human-readable version of this.
| email_recipients: ${{ github.event.inputs.recipients || secrets.ANTITHESIS_RECIPIENTS }} | ||
| additional_parameters: |- | ||
| custom.duration=${{ github.event.inputs.duration || '0.5' }} | ||
| custom.duration=${{ github.event.inputs.duration || '11.25' }} |
There was a problem hiding this comment.
For my own knowledge, what are the units here?
There was a problem hiding this comment.
Updated input labels and added comments indicating units of duration
The proposed schedule mirrors the current schedule implemented on the antithesis side.
marun
force-pushed
the
antithesis-add-schedule
branch
from
4c1f753 to
3caba51
Compare
StephenButtolph
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed schedule mirrors the current schedule implemented on the antithesis side.