Skip to content

Make metrics more fine-grained #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2024
Merged

Make metrics more fine-grained #2778

merged 2 commits into from
Feb 28, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

  • Adds an average lifetime metric
  • Separates metrics for unsent and sent transactions
  • Cleans up some naming

How this works

We now track the sum of all the times that each transaction was added to the pusher. We can then easily calculate the average addition time and compare it to the current time to calculate the average lifetime.

How this was tested

  • Locally the metrics show up as expected:
# HELP avalanche_P_vm_tx_gossip_tracking number of gossipables being tracked
# TYPE avalanche_P_vm_tx_gossip_tracking gauge
avalanche_P_vm_tx_gossip_tracking{type="sent"} 0
avalanche_P_vm_tx_gossip_tracking{type="unsent"} 0
# HELP avalanche_P_vm_tx_gossip_tracking_lifetime_average average duration a gossipable has been tracked (ns)
# TYPE avalanche_P_vm_tx_gossip_tracking_lifetime_average gauge
avalanche_P_vm_tx_gossip_tracking_lifetime_average 0
  • Metrics are updated as expected when issuing a transaction
  • CI

@StephenButtolph StephenButtolph added the monitoring This primarily focuses on logs, metrics, and/or tracing label Feb 28, 2024
@StephenButtolph StephenButtolph self-assigned this Feb 28, 2024
patrick-ogrady
patrick-ogrady reviewed Feb 28, 2024
View reviewed changes
network/p2p/gossip/gossip.go
}
p.metrics.tracking.Set(float64(len(p.tracking)))

p.metrics.tracking.With(unsentLabels).Set(numUnsent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

patrick-ogrady
patrick-ogrady reviewed Feb 28, 2024
View reviewed changes
@StephenButtolph StephenButtolph merged commit 1cbea42 into gossip-cleanup Feb 28, 2024
@StephenButtolph StephenButtolph deleted the add-average-lifetime-metric branch February 28, 2024 18:26
mboben pushed a commit to mboben/avalanchego that referenced this pull request Apr 7, 2024
@StephenButtolph @dhrubabasu
Add example usage for the X-chain block indexer API (ava-labs#2778)
ca4c32f 
Co-authored-by: Dan Laine <daniel.laine@avalabs.org>
Co-authored-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlaine danlaine Awaiting requested review from danlaine

@joshua-kim joshua-kim Awaiting requested review from joshua-kim

1 more reviewer

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephenButtolph StephenButtolph

Labels
monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
avalanchego
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenButtolph @patrick-ogrady