Move avm.newContext to snowtest.Context
#2513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
added
testing
dhrubabasu
changed the title
snowtest.NewContext helperavm.newContext to snowtest.NewContext
abi87
reviewed
Dec 20, 2023
abi87
reviewed
Dec 20, 2023
abi87
reviewed
Dec 20, 2023
abi87
reviewed
Dec 20, 2023
abi87
suggested changes
Dec 20, 2023
There was a problem hiding this comment.
I'd modify snowtest.Context constructor to specify the target chain, instead of fixing it ex-psto via ctx.ChainID = ctx.XChainID.
We are already not doing it for all the UTs and it may become harder to maintain if we ever change context attributes relationships.
I think ideally snowtest.Context should fully format the context and tests should just read from it
abi87
approved these changes
Dec 21, 2023
StephenButtolph
approved these changes
Dec 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes all one-off test helpers in the
avmto use a newsnowtest.Contexthelper.How this works
create + replace
How this was tested
CI