nits #2375
Closed
nits #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine,
StephenButtolph and
ceyonur
as code owners
dhrubabasu
commented
Nov 27, 2023
| @@ -1447,7 +1447,7 @@ func (s *state) loadCurrentValidators() error { | |||
| } | |||
| tx, _, err := s.GetTx(txID) | |||
| if err != nil { | |||
| return fmt.Errorf("failed loading validator transaction txID %v, %w", txID, err) | |||
| return err | |||
There was a problem hiding this comment.
We don't wrap this elsewhere in this method (or this file)
dhrubabasu
commented
Nov 27, 2023
| @@ -136,7 +135,7 @@ func NextBlockTime(state state.Chain, clk *mockable.Clock) (time.Time, bool, err | |||
|
|
|||
| nextStakerChangeTime, err := GetNextStakerChangeTime(state) | |||
| if err != nil { | |||
| return time.Time{}, false, fmt.Errorf("could not calculate next staker change time: %w", err) | |||
| return time.Time{}, false, err | |||
There was a problem hiding this comment.
This should be wrapped by the caller since it's the only error that can be returned in this func
danlaine
reviewed
Nov 27, 2023
utils/logging/log.go
Outdated
| @@ -67,7 +68,9 @@ func (l *log) Write(p []byte) (int, error) { | |||
| // TODO: return errors here | |||
| func (l *log) Stop() { | |||
| for _, wc := range l.wrappedCores { | |||
| _ = wc.Writer.Close() | |||
| if wc.Writer != os.Stdout && wc.Writer != os.Stderr { | |||
|
absorbed by #2335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.