Skip to content

Rename AppRequestFailed to AppError #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Rename AppRequestFailed to AppError #2321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions proto/p2p/p2p.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ message Message {
AppGossip app_gossip = 32;

PeerListAck peer_list_ack = 33;
AppRequestFailed app_request_failed = 34;
AppError app_error = 34;
}
}

Expand Down Expand Up @@ -387,7 +387,7 @@ message Chits {
// AppRequest is a VM-defined request.
//
// Remote peers must respond to AppRequest with a corresponding AppResponse or
// AppRequestFailed
// AppError
message AppRequest {
// Chain being requested from
bytes chain_id = 1;
Expand All @@ -409,8 +409,8 @@ message AppResponse {
bytes app_bytes = 3;
}

// AppRequestFailed is a VM-defined error sent in response to AppRequest
message AppRequestFailed {
// AppError is a VM-defined error sent in response to AppRequest
message AppError {
// Chain the message is for
bytes chain_id = 1;
// Request id of the original AppRequest
Expand Down
Loading