platformvm.VM -- replace Config field with validators.Manager
#2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
changed the title
platformvm.VM -- replace Config field with validators.Manager
dhrubabasu
approved these changes
Nov 15, 2023
abi87
reviewed
Nov 17, 2023
| ctx *snow.Context | ||
| metrics metrics.Metrics | ||
| rewards reward.Calculator | ||
| validators validators.Manager |
There was a problem hiding this comment.
@danlaine I think the reason we have the full config here is that we used to need more config fields before introducing config.ExecutionConfig.
Anyhow now your cleanup makes much sense
abi87
approved these changes
Nov 17, 2023
StephenButtolph
approved these changes
Nov 17, 2023
joshua-kim
added a commit
that referenced
this pull request
Nov 20, 2023
commit 40934bb Author: Dan Laine <daniel.laine@avalabs.org> Date: Fri Nov 17 15:26:22 2023 -0500 `platformvm.VM` -- replace `Config` field with `validators.Manager` (#2319) commit a803f38 Author: Stephen Buttolph <stephen@avalabs.org> Date: Fri Nov 17 15:14:36 2023 -0500 Remove common.Config from syncer.Config (#2330) commit dbc209c Author: Stephen Buttolph <stephen@avalabs.org> Date: Fri Nov 17 14:48:54 2023 -0500 Export snowman bootstrapper (#2331) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
added a commit
that referenced
this pull request
Nov 20, 2023
commit 40934bb Author: Dan Laine <daniel.laine@avalabs.org> Date: Fri Nov 17 15:26:22 2023 -0500 `platformvm.VM` -- replace `Config` field with `validators.Manager` (#2319) commit a803f38 Author: Stephen Buttolph <stephen@avalabs.org> Date: Fri Nov 17 15:14:36 2023 -0500 Remove common.Config from syncer.Config (#2330) commit dbc209c Author: Stephen Buttolph <stephen@avalabs.org> Date: Fri Nov 17 14:48:54 2023 -0500 Export snowman bootstrapper (#2331) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We only use one field of
Config. This PR parameterizesVMon that one field instead of the entireConfigstruct.How this works
Self-explanatory.
How this was tested
Existing UT.