merkledb -- don't pass BranchFactor to encodeDBNode
#2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2023 10:56
Signed-off-by: Dan Laine <daniel.laine@avalabs.org>
Signed-off-by: Dan Laine <daniel.laine@avalabs.org>
dboehm-avalabs
approved these changes
Oct 26, 2023
added 2 commits
October 26, 2023 14:24
Signed-off-by: Dan Laine <daniel.laine@avalabs.org>
Signed-off-by: Dan Laine <daniel.laine@avalabs.org>
joshua-kim
added a commit
that referenced
this pull request
Oct 27, 2023
commit a4cee60 Author: Dan Laine <daniel.laine@avalabs.org> Date: Fri Oct 27 11:37:05 2023 -0400 `merkledb` -- don't pass `BranchFactor` to `encodeDBNode` (#2217) Signed-off-by: Dan Laine <daniel.laine@avalabs.org> commit cacbb9b Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Date: Thu Oct 26 16:57:56 2023 -0400 Move all blst function usage to `bls` pkg (#2222) Signed-off-by: Dan Laine <daniel.laine@avalabs.org> Co-authored-by: Dan Laine <daniel.laine@avalabs.org> commit 3b213fc Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Date: Thu Oct 26 16:53:26 2023 -0400 Add json marshal tests to existing serialization tests in `platformvm/txs` pkg (#2227) commit a6448ac Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Date: Thu Oct 26 16:48:00 2023 -0400 Update `golangci-lint` to `v1.55.1` (#2228) commit fe74ed1 Author: Dan Laine <daniel.laine@avalabs.org> Date: Thu Oct 26 12:54:34 2023 -0400 `merkledb` -- shift nit (#2218) Signed-off-by: Dan Laine <daniel.laine@avalabs.org> commit e933587 Author: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com> Date: Thu Oct 26 11:40:57 2023 -0400 Reduce allocations on insert and remove (#2201) Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com> Signed-off-by: Dan Laine <daniel.laine@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Dan Laine <daniel.laine@avalabs.org> commit 638000c Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Oct 26 02:08:05 2023 -0400 Update versions for v1.10.14 (#2225) commit 8463690 Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Oct 26 00:12:05 2023 -0400 Improve logging for block verification failure (#2224) commit 787f0b6 Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Oct 25 17:35:17 2023 -0400 Fix unexpected unlock (#2221) commit 1f779af Author: Stephen Buttolph <stephen@avalabs.org> Date: Wed Oct 25 17:13:25 2023 -0400 Revert networking AllowConnection change (#2219) commit f020a05 Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Date: Wed Oct 25 16:51:24 2023 -0400 Add `TransferSubnetOwnershipTx` (#2178) Signed-off-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> commit 150ffae Author: Dan Laine <daniel.laine@avalabs.org> Date: Wed Oct 25 16:39:10 2023 -0400 Add pebble database implementation (#1999) Co-authored-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit de168b1 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Wed Oct 25 15:47:48 2023 -0400 Add log for ungraceful shutdown on startup (#2215) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> commit cd77a1e Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Date: Wed Oct 25 13:27:43 2023 -0400 Remove `aggregate` struct (#2213) commit 128757d Author: Ceyhun Onur <ceyhun.onur@avalabs.org> Date: Wed Oct 25 02:03:45 2023 +0300 Move the overridden manager into the node (#2199) Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Co-authored-by: Alberto Benegiamo <alberto.benegiamo@gmail.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit 7903676 Author: Ceyhun Onur <ceyhun.onur@avalabs.org> Date: Tue Oct 24 20:44:01 2023 +0300 Remove contains from validator manager interface (#2198) Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Signed-off-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Alberto Benegiamo <alberto.benegiamo@gmail.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit 963aeb0 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Tue Oct 24 12:54:31 2023 -0400 Update TestDialContext to use ManuallyTrack (#2209) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> commit e337dda Author: Stephen Buttolph <stephen@avalabs.org> Date: Tue Oct 24 12:42:05 2023 -0400 Remove duplicate networking check (#2204) Signed-off-by: Dan Laine <daniel.laine@avalabs.org> Co-authored-by: Dan Laine <daniel.laine@avalabs.org> commit 020e802 Author: Stephen Buttolph <stephen@avalabs.org> Date: Mon Oct 23 17:37:14 2023 -0400 Add RSA max key length test (#2205) commit d3287dd Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Mon Oct 23 12:09:10 2023 -0700 Use custom codec for validator metadata (#1510) commit 3a1dcca Author: Stephen Buttolph <stephen@avalabs.org> Date: Mon Oct 23 13:47:37 2023 -0400 Update local network readme (#2203) commit 7b7931b Author: Ceyhun Onur <ceyhun.onur@avalabs.org> Date: Mon Oct 23 20:36:47 2023 +0300 Redesign validator set management to enable tracking all subnets (#1857) Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Co-authored-by: Alberto Benegiamo <alberto.benegiamo@gmail.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit 4cd7051 Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Mon Oct 23 08:48:56 2023 -0700 Shutdown TimeoutManager during node Shutdown (#1707) Signed-off-by: Alberto Benegiamo <alberto.benegiamo@gmail.com> Co-authored-by: Dan Laine <daniel.laine@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> commit 6624270 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Mon Oct 23 11:37:03 2023 -0400 Add Heap Set (#2136) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Signed-off-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Co-authored-by: dboehm-avalabs <david.boehm@avalabs.org> Co-authored-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com> Co-authored-by: Alberto Benegiamo <alberto.benegiamo@gmail.com> commit 804f45b Author: Stephen Buttolph <stephen@avalabs.org> Date: Fri Oct 20 14:16:44 2023 -0400 Move selectStartGear lock from Handler into Engines (#2182) commit 7ed450b Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Fri Oct 20 09:55:40 2023 -0400 Implement Heap Map (#2137) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Co-authored-by: Alberto Benegiamo <alberto.benegiamo@gmail.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit a21d0cf Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Oct 19 18:13:46 2023 -0400 Move HealthCheck lock from Handler into Engines (#2173) commit 26b1505 Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Oct 19 17:48:22 2023 -0400 Move Shutdown lock from Handler into Engines (#2179) commit 8c6b9d3 Author: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Date: Thu Oct 19 15:36:31 2023 -0400 Add tests for BanffBlock serialization (#2194) commit d9460de Author: Dan Laine <daniel.laine@avalabs.org> Date: Thu Oct 19 15:26:16 2023 -0400 Deprecate keystore config (#2195) commit a9c260b Author: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com> Date: Thu Oct 19 14:44:51 2023 -0400 Merkle db Make Paths only refer to lists of nodes (#2143) Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> commit 0faab95 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Thu Oct 19 14:43:29 2023 -0400 Update P2P proto docs (#2181) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit 927c23d Author: Dan Laine <daniel.laine@avalabs.org> Date: Thu Oct 19 13:07:46 2023 -0400 Deprecate IPC configs (#2168) Co-authored-by: Stephen Buttolph <stephen@avalabs.org> commit 3b843a3 Author: Stephen Buttolph <stephen@avalabs.org> Date: Thu Oct 19 12:14:58 2023 -0400 Update cgo usage (#2184) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We don't need this variable. Changes originally from #2197
How this works
Remove parameter.
How this was tested
Existing UT.