Cleanup uptime manager constructor #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
requested review from
danlaine,
StephenButtolph,
ceyonur and
joshua-kim
as code owners
abi87
commented
Sep 29, 2023
abi87
commented
Sep 29, 2023
abi87
force-pushed
the
fix_platformVM_UTs_2
branch
from
3657e8c to
d594c57
Compare
StephenButtolph
added
vm
StephenButtolph
approved these changes
Sep 29, 2023
dhrubabasu
approved these changes
Sep 29, 2023
JacobEverly
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In platformvm we take care of passing vm.Clock to vm objects as a reference to be able to set time in test for all objects at the same time. uptime.Manager was not built that way and had its own SetTime method to explicitly control time in UTs. This PR fixes the situation and make uptime.Manager handle time as other platformVM objects
How this works
Drop TestManager interface, drop SetTime method, pass clock reference in uptime.Manager ctor
How this was tested
CI