e2e: Ensure all Issue* calls use the default context #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
approved these changes
Sep 22, 2023
marun
force-pushed
the
e2e-moar-context
branch
from
10f80b4 to
39a2eb5
Compare
abi87
approved these changes
Sep 25, 2023
StephenButtolph
approved these changes
Sep 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Some of the recently merged kurtosis test PRs were not setting contexts which resulted in hour-long timeouts when a flake occurred.
How this works
Ensure all Issue* calls use
e2e.WithDefaultContext.How this was tested
CI