Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pebble database implementation #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pebble database implementation #1999
Changes from 20 commits
d24ee4c
d578d00
db2eeeb
0983042
528cc2d
1bcfa65
73a934f
1e094b4
5f39300
d937e6c
721275e
5a8d855
9f7665b
1db44c4
7e4cf61
4051e88
4bc0630
662975f
cd0a8e2
261e710
59a8615
a710f54
f21c81d
cc7a15e
f9192ed
155edc9
72a249d
4b08b25
b8fa698
a1b7fba
6b93c90
610e7f8
fc91cd1
5aff591
49499fa
bba3048
3ffc6a8
a8ff7b8
c6bacc7
b886790
f771665
3412216
f0e3f2e
c4d1a87
d379e77
8eea9eb
c350116
b64de08
b1768c1
afd88e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it isn't used - but wondering if this would be cleaner if we passed in
pebble.Sync
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...I don't feel super strongly. If we pass in
pebble.Sync
then people looking at this code in the future might think that we think now that the value does something, even though it doesn't. We could just put a comment saying that we know it isn't used, but it feels weird to be like "this does nothing but we're gonna do it anyway." So I'd lean toward leaving it but w/e