Skip to content

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

GetValue and GetValues can be extremely noisy, so this suppresses them by default.

How this works

  • Adds DebugTrace, InfoTrace, and NoTrace as possible configurations of the merkledb tracing.
  • Also cleaned up noop tracing to be more user friendly.

How this was tested

CI

@StephenButtolph StephenButtolph added this to the v1.10.10 milestone Aug 27, 2023
@StephenButtolph StephenButtolph added the monitoring This primarily focuses on logs, metrics, and/or tracing label Aug 27, 2023
@StephenButtolph StephenButtolph self-assigned this Aug 27, 2023
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as you add back GetValue tracing in the TrieView

@patrick-ogrady
Copy link
Contributor

YUGE

@StephenButtolph StephenButtolph merged commit 62cadd8 into dev Aug 27, 2023
@StephenButtolph StephenButtolph deleted the merkledb-trace-levels branch August 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants