Skip to content

Restricted tls metrics #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 24, 2023
Merged

Restricted tls metrics #1924

merged 4 commits into from
Aug 24, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Enables monitoring of invalid cert usage.

How this works

Adds a metric

How this was tested

Ran a local node and made sure the metrics showed up:

# HELP avalanche_network_tls_conn_rejected Times this node rejected a connection due to an unsupported TLS certificate
# TYPE avalanche_network_tls_conn_rejected counter
avalanche_network_tls_conn_rejected 0

@StephenButtolph StephenButtolph added this to the v1.10.9 milestone Aug 24, 2023
@StephenButtolph StephenButtolph added monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking labels Aug 24, 2023
Base automatically changed from initial-restrict-tls to dev August 24, 2023 22:06
@StephenButtolph StephenButtolph merged commit 4db53b1 into dev Aug 24, 2023
@StephenButtolph StephenButtolph deleted the restricted-tls-metrics branch August 24, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlaine danlaine Awaiting requested review from danlaine

@joshua-kim joshua-kim Awaiting requested review from joshua-kim joshua-kim is a code owner

@abi87 abi87 Awaiting requested review from abi87

@gyuho gyuho Awaiting requested review from gyuho

@marun marun Awaiting requested review from marun

2 more reviewers

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
monitoring This primarily focuses on logs, metrics, and/or tracing networking This involves networking
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.9
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @dhrubabasu @patrick-ogrady