-
Notifications
You must be signed in to change notification settings - Fork 741
testing: Switch upgrade test to testnet fixture #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4af50a7
to
08008bd
Compare
1f05a20
to
46a2964
Compare
00ac73e
to
32fab40
Compare
1 task
3d69581
to
0a1f380
Compare
e491b59
to
46f06f8
Compare
Rebased |
48749af
to
9d83172
Compare
9cc4fee
to
0a41e56
Compare
0a41e56
to
17bc212
Compare
StephenButtolph
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 super small comment. LGTM
29f8c43
to
f388171
Compare
dhrubabasu
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Switching the upgrade test to the testnet fixture ensures a consistent maintenance experience between e2e and upgrade tests. This also removes a dependency on
github.com/ava-labs/avalanche-network-runner-sdk
, allowing it to be deprecated once this PR merges.How this works
How this was tested
CI
TODO