Skip to content

testing: Switch upgrade test to testnet fixture #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

marun
Copy link
Contributor

@marun marun commented Aug 21, 2023

Why this should be merged

Switching the upgrade test to the testnet fixture ensures a consistent maintenance experience between e2e and upgrade tests. This also removes a dependency on github.com/ava-labs/avalanche-network-runner-sdk, allowing it to be deprecated once this PR merges.

How this works

  • Rewrites the upgrade test to use the testnet fixture
  • Requires avalanchego >= 1.10.7 since that's the first release that writes the process context file that the testnet fixture depends on

How this was tested

CI

TODO

@marun marun changed the title Switch upgrade test to testnet testing: Switch upgrade test to testnet fixture Aug 21, 2023
@marun marun added testing This primarily focuses on testing e2e-migrate-kurtosis labels Aug 21, 2023
@marun marun force-pushed the switch-upgrade-test-to-testnet branch 4 times, most recently from 4af50a7 to 08008bd Compare August 22, 2023 00:03
@marun marun self-assigned this Aug 23, 2023
@marun marun force-pushed the switch-upgrade-test-to-testnet branch 6 times, most recently from 1f05a20 to 46a2964 Compare September 1, 2023 18:37
@marun marun force-pushed the switch-upgrade-test-to-testnet branch 2 times, most recently from 00ac73e to 32fab40 Compare September 5, 2023 21:52
@marun marun force-pushed the switch-upgrade-test-to-testnet branch from 3d69581 to 0a1f380 Compare September 7, 2023 01:16
@marun marun force-pushed the switch-upgrade-test-to-testnet branch 2 times, most recently from e491b59 to 46f06f8 Compare September 21, 2023 06:48
@marun
Copy link
Contributor Author

marun commented Sep 21, 2023

Rebased

@marun marun force-pushed the switch-upgrade-test-to-testnet branch 2 times, most recently from 48749af to 9d83172 Compare September 21, 2023 20:00
@marun marun force-pushed the switch-upgrade-test-to-testnet branch 4 times, most recently from 9cc4fee to 0a41e56 Compare September 25, 2023 10:11
@marun marun marked this pull request as ready for review September 25, 2023 10:13
@marun marun requested a review from abi87 as a code owner September 25, 2023 10:13
@marun marun requested a review from hexfusion September 25, 2023 10:14
@marun marun force-pushed the switch-upgrade-test-to-testnet branch from 0a41e56 to 17bc212 Compare September 25, 2023 17:08
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 super small comment. LGTM

@marun marun force-pushed the switch-upgrade-test-to-testnet branch from 29f8c43 to f388171 Compare September 28, 2023 17:24
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Sep 28, 2023
@StephenButtolph StephenButtolph merged commit 5be3adc into dev Sep 28, 2023
@StephenButtolph StephenButtolph deleted the switch-upgrade-test-to-testnet branch September 28, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants