Simplify exported interface of the primary wallet #1849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
sdk
marun
approved these changes
Aug 14, 2023
dhrubabasu
reviewed
Aug 15, 2023
dhrubabasu
approved these changes
Aug 15, 2023
Co-authored-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com> Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
felipemadero
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently the exported functions for creating a wallet are very ugly. There is no reason for such similar functions to exist as separate functions.
How this works
Converts 4 exported functions into 1 single exported function.
How this was tested
NewWalletWithTxsAndState... But someone using this function should really just be usingNewWallet(if at all) - as they are heavily customizing the wallet.