Migrate to uber-go/mock
#1840
Merged
Migrate to uber-go/mock
#1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
danlaine,
darioush,
dboehm-avalabs,
joshua-kim,
hexfusion,
StephenButtolph,
abi87,
coffeeavax,
ceyonur and
gyuho
as code owners
joshua-kim
approved these changes
Aug 10, 2023
dhrubabasu
commented
Aug 11, 2023
Signed-off-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
|
Note: if you try running the mock gen script with the old version of mockgen installed - you get some pretty confusing errors. You'll need to explicitly run the install command included in the script if this happens. |
StephenButtolph
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
golang/mockis no longer maintained as of June 2023 (see repo disclaimer).uber-go/mockis the maintained fork and is linked to by thegolang/mockauthors.How this works
find and replace :)
How this was tested
CI