Add error logs for unexpected proposervm BuildBlock failures #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Aug 9, 2023
Comment on lines
+267
to
+272
| p.vm.ctx.Log.Error("unexpected build block failure", | ||
| zap.String("reason", "failed to generate proposervm block header"), | ||
| zap.Stringer("parentID", parentID), | ||
| zap.Stringer("blkID", innerBlock.ID()), | ||
| zap.Error(err), | ||
| ) |
There was a problem hiding this comment.
Erroring here technically won't cause an invariant break... However, it's unexpected so I felt like logging an error here still made sense.
| zap.String("reason", "failed to calculate required timestamp delay"), | ||
| zap.Stringer("parentID", parentID), | ||
| zap.Error(err), | ||
| ) | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Notice that we do not log an error below here if if delay < minDelay { as that can happen normally and is handled gracefully.
StephenButtolph
added
vm
patrick-ogrady
approved these changes
Aug 9, 2023
hexfusion
approved these changes
Aug 9, 2023
dhrubabasu
reviewed
Aug 9, 2023
dhrubabasu
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Failing to build a block inside the proposervm unexpectedly can violate the consensus invariant that
BuildBlockwill be called at least once after receiving aPendingTxsmessage.How this works
If the proposervm fails to build a block outside of the inner vm's control, an error should be logged. The exception to this is if the proposervm windower hasn't progressed far enough to attempt to build a block. In this case, we manually mock a
PendingTxsmessage from the inner VM.How this was tested
N/A