Add CI check that auto-generated code is up to date #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
coffeeavax,
gyuho and
hexfusion
as code owners
This reverts commit 84884e0.
darioush
approved these changes
Aug 9, 2023
joshua-kim
reviewed
Aug 9, 2023
marun
reviewed
Aug 9, 2023
marun
reviewed
Aug 9, 2023
This reverts commit f9d2636.
Merged
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
This reverts commit adb8e95.
joshua-kim
approved these changes
Aug 16, 2023
| - shell: bash | ||
| run: scripts/mock.gen.sh | ||
| - shell: bash | ||
| run: rm -rf gomock_reflect* |
There was a problem hiding this comment.
Is this mostly for if the previous run failed in a weird state?
There was a problem hiding this comment.
Yeah- thinking about it again we should fail if that file still exists. Updated the PR
marun
reviewed
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #1553
How this works
Adds a workflow that runs both code generation scripts and checks that the working tree is clean.
How this was tested
CI