Skip to content

Add support for measuring key size in caches #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2023
Merged

Add support for measuring key size in caches #1781

merged 3 commits into from
Jul 31, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

  1. Unblocks Evict blocks based on size #1766
  2. Keys can have variable lengths, so we should be able to measure their overhead.

How this works

Extends the size to also take in the Key for the SizedLRU cache.

How this was tested

Existing CI.

@StephenButtolph StephenButtolph added the sdk This involves SDK tooling or frameworks label Jul 31, 2023
@StephenButtolph StephenButtolph added this to the v1.10.6 milestone Jul 31, 2023
@StephenButtolph StephenButtolph self-assigned this Jul 31, 2023
patrick-ogrady
patrick-ogrady previously approved these changes Jul 31, 2023
View reviewed changes
hexfusion
hexfusion previously approved these changes Jul 31, 2023
View reviewed changes
@StephenButtolph StephenButtolph dismissed stale reviews from patrick-ogrady and hexfusion July 31, 2023 17:47

found a bug

@StephenButtolph StephenButtolph merged commit 3bd1a1a into dev Jul 31, 2023
@StephenButtolph StephenButtolph deleted the add-key-size-cache branch July 31, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abi87 abi87 Awaiting requested review from abi87

@danlaine danlaine Awaiting requested review from danlaine

2 more reviewers

@hexfusion hexfusion hexfusion approved these changes

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@StephenButtolph StephenButtolph

Labels
sdk This involves SDK tooling or frameworks
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.7
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @hexfusion @patrick-ogrady