Export warp errors for external use #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
StephenButtolph
approved these changes
Jul 27, 2023
darioush
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR exports the un-exported warp errors, so that they can be consumed by an external package. For example, in Subnet-EVM we copy the same test coverage from AvalancheGo warp to ensure that any change in behavior will be noticed and picked up by those tests.
Exporting these variables ensures that we can add the same test coverage and assert an exact error match.
If we'd prefer to draw a different line between them and assume that Subnet-EVM will depend on AvalancheGo for this test coverage and only worry about whether
signature.Verify(...)returns true or false, then we should close this PR.How this works
Exports the previously un-exported errors in the warp package.
How this was tested
CI