Add ids length constants #1759
Merged
Add ids length constants #1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
danlaine,
darioush,
dboehm-avalabs and
joshua-kim
as code owners
joshua-kim
approved these changes
Jul 25, 2023
abi87
reviewed
Jul 25, 2023
| const nullStr = "null" | ||
| const ( | ||
| IDLen = 32 | ||
| nullStr = "null" |
There was a problem hiding this comment.
json decoding.
There was a problem hiding this comment.
Also had this question... Go uses this as a sentinel value:
// Unmarshaler is the interface implemented by types
// that can unmarshal a JSON description of themselves.
// The input can be assumed to be a valid encoding of
// a JSON value. UnmarshalJSON must copy the JSON data
// if it wishes to retain the data after returning.
//
// By convention, to approximate the behavior of Unmarshal itself,
// Unmarshalers implement UnmarshalJSON([]byte("null")) as a no-op.
type Unmarshaler interface {
UnmarshalJSON([]byte) error
}
abi87
reviewed
Jul 25, 2023
| const NodeIDPrefix = "NodeID-" | ||
| const ( | ||
| NodeIDPrefix = "NodeID-" | ||
| NodeIDLen = ShortIDLen |
dhrubabasu
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Rather than relying on the
hashingpackage constants - it's more user friendly to expose the constants from theidspackage.How this works
Move constants.
How this was tested
N/A